refactor: cleanup public actions API

[trueberryless]

Changes

• Refactor public API of actions to reduce what is exported (introduce new /entrypoints/{server|client}.ts files)
• Cleanup additional internals regarding actions
• Closes Cleanup actions public API #14608

Testing

I adapted some imports in test since the refactoring affects some.

Docs

No docs changed, this PR is intended to just refactor internal exports and remove public access to some types.
The docs were already adapted in withastro/docs#12596

Todo

• Write a proper changeset with breaking changes once I understand what I actually need to do 😅

[changeset-bot]

🦋 Changeset detected

Latest commit: db29578

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #14844 will not alter performance

_{Comparing trueberryless:refactor/tbl-14608-cleanup-actions-public-api (283ea2e) with main (78ed8b5)¹}

Summary

✅ 6 untouched

Footnotes

1. No successful run was found on main (e878679) during the generation of this report, so 78ed8b5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[florian-lefebvre]

First of all, the PR should be against the next branch!

[trueberryless]

First of all, the PR should be against the next branch!

I'm gonna do it better next time 😅

[florian-lefebvre]

Do you need help?

[trueberryless]

Hi, Florian!

That would be awesome, as I'm not totally sure what else to edit 🙏

[florian-lefebvre]

The 2 last bullet points of the issue are handled, nicely done! Many things are missing from the 1st bullet point tho:

• Currently you're only exporting some types but that is not enough. You should re-export also runtime utils. Basically all the things documented in https://docs.astro.build/en/reference/modules/astro-actions/
• Old entrypoints must be removed if possible
• In the actions vite plugin, you should update paths to point to the new files

Does that make sense? Happy to clarify

[trueberryless]

Thanks Florian for the explanation, this made it much more clear to me 🙌

Regarding

In the actions vite plugin, you should update paths to point to the new files

I'm not totally sure, where you mean, I think I adapted it already, but I probably overlooked some place, so I updated it in the last commit again, please let me know, if I am completely mistaken here and which changes are actually required 🙏

Old entrypoints must be removed if possible

In the last commit, I moved as much things that are now exported from /entrypoints to the shared.ts instead of server.ts and completely deleted the runtime/client.ts file. I think the only thing that should still stay in server.ts is ActionClient, which therefore is still exported.

Also let me know if you would prefer some other ordering / structuring in the new entrypoint files, I grouped it by type vs functions/classes 👍

All in all, I'm pretty sure I missed some other things, but I really appreciate your guidance and patience! Thank you!

[trueberryless]

Also, I just noticed this PR is still in draft mode. I think now is the time to mark it as ready for review to encourage reviews 🙌

[trueberryless]

I'll also fix the CI issues later, I think they are self-explanatory 👍

[florian-lefebvre]

When I talk about the vite plugin, I'm talking about this line specifically https://github.com/withastro/astro/blob/next/packages/astro/src/actions/vite-plugin-actions.ts#L117

[trueberryless]

When I talk about the vite plugin, I'm talking about this line specifically next/packages/astro/src/actions/vite-plugin-actions.ts#L117

Thanks very much for clarifying that! I was unable to find it myself, sorry!

[trueberryless]

Thank you so much, Florian, for helping out and cleaning up many 👀 important parts of code. I definitely couldn't have done that without you. Thanks for also being so patient with me and always offering help 🙌

As you can probably see, I created the docs PR for this breaking change, where I listed all removed utilities to my knowledge. I'm not sure if this is the best approach, but let's discuss these details over there 👍

[florian-lefebvre]

Perfect thank you! It may take a few days to merge this because we want to merge another PR first