feat(astro)!: stabilize failOnPrerenderConflict

[florian-lefebvre]

Changes

• Closes Stabilize experimental.failOnPrerenderConflict #14379
• Removes experimental.failOnPrerenderConflict in favor or prerenderConflictBehavior

Testing

Updated, should pass

Docs

Changeset + withastro/docs#12745

[changeset-bot]

🦋 Changeset detected

Latest commit: d0e5e2b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Fryuni]

Lovely! Thanks Florian!

[ematipico]

Awesome

[sarah11918]

Just a couple of things to note!

This is a "top-level" config option, so the JSDoc needs to be added up in that section (see the docs PR, I'm suggesting after scopedStyleStrategy, but those are just arbitrarily listed by how "popular" we think the options are. It can go anywhere in that list. (In its current location, this would show up as an env configuration option.)

I know you're reusing the error message, so you haven't added/updated anything. BUT now that we have this config option, I think the error message (https://docs.astro.build/en/reference/errors/prerender-route-conflict/) could probably be updated to show more helpful links:

• the link directly to route priority (probably more helpful than either of the existing links to getStaticPaths() or params?)
• this new config option so that you can configure whether or not to see this message, maybe? (It can be a helpful reminder if someone sets error, then gets annoyed and wants to silence it, if the link to the config option is directly in the error message I think?) What do you think?

[sarah11918]

LGTM! I updated all the suggestions to warn instead of warnING, in case that's helpful!

[sarah11918]

LGTM! 🚀