Skip to content

Conversation

@aprici7y
Copy link
Contributor

Fixes #14575

Summary

Restores Astro.site availability in getStaticPaths() by adding back the astroGlobalArgs compiler option that was removed in PR #14405.

Bug

In v5.13.10, Astro.site became undefined when accessed inside getStaticPaths(), even when properly configured in astro.config.mjs.

Root Cause

PR #14405 removed the astroGlobalArgs parameter from the compiler options. This parameter passes the site configuration to the Astro compiler, which injects it into the compiled component, making Astro.site available in the frontmatter code (including getStaticPaths()).

Fix

This PR restores the single line that was removed:

astroGlobalArgs: JSON.stringify(astroConfig.site),

Testing

Verified that Astro.site is now correctly available in getStaticPaths() as a URL object with the configured site value.

Before (v5.13.10)

  • Astro.site in getStaticPaths(): undefined

After (with this fix)

  • Astro.site in getStaticPaths(): URL { href: 'https://example.com/', ... }

Restores the astroGlobalArgs compiler option that was removed in withastro#14405. This parameter is needed to pass the site config to the compiler so Astro.site is available in getStaticPaths().
@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2025

🦋 Changeset detected

Latest commit: 1bca9dd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 19, 2025

CodSpeed Performance Report

Merging #14576 will not alter performance

Comparing aprici7y:fix/astro-site-getstaticpaths (1bca9dd) with main (2af62c6)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (077b19b) during the generation of this report, so 2af62c6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@florian-lefebvre florian-lefebvre merged commit 2af62c6 into withastro:main Oct 20, 2025
6 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Oct 20, 2025
richardnbanks pushed a commit to richardnbanks/astro-loader-youtube that referenced this pull request Oct 22, 2025
This PR contains the following updates:

| Package | Change | Age | Confidence |
|---|---|---|---|
| [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`5.14.6` -> `5.14.8`](https://renovatebot.com/diffs/npm/astro/5.14.6/5.14.8) | [![age](https://developer.mend.io/api/mc/badges/age/npm/astro/5.14.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/astro/5.14.6/5.14.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [googleapis](https://github.com/googleapis/google-api-nodejs-client) | [`164.0.0` -> `164.1.0`](https://renovatebot.com/diffs/npm/googleapis/164.0.0/164.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/googleapis/164.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/googleapis/164.0.0/164.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>withastro/astro (astro)</summary>

### [`v5.14.8`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#5148)

[Compare Source](https://github.com/withastro/astro/compare/[email protected]@5.14.8)

##### Patch Changes

- [#&#8203;14590](withastro/astro#14590) [`577d051`](withastro/astro@577d051) Thanks [@&#8203;matthewp](https://github.com/matthewp)! - Fixes image path resolution in content layer collections to support bare filenames. The `image()` helper now normalizes bare filenames like `"cover.jpg"` to relative paths `"./cover.jpg"` for consistent resolution behavior between markdown frontmatter and JSON content collections.

### [`v5.14.7`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#5147)

[Compare Source](https://github.com/withastro/astro/compare/[email protected]@5.14.7)

##### Patch Changes

- [#&#8203;14582](withastro/astro#14582) [`7958c6b`](withastro/astro@7958c6b) Thanks [@&#8203;florian-lefebvre](https://github.com/florian-lefebvre)! - Fixes a regression that caused Actions to throw errors while loading

- [#&#8203;14567](withastro/astro#14567) [`94500bb`](withastro/astro@94500bb) Thanks [@&#8203;matthewp](https://github.com/matthewp)! - Fixes the actions endpoint to return 404 for non-existent actions instead of throwing an unhandled error

- [#&#8203;14566](withastro/astro#14566) [`946fe68`](withastro/astro@946fe68) Thanks [@&#8203;matthewp](https://github.com/matthewp)! - Fixes handling malformed cookies gracefully by returning the unparsed value instead of throwing

  When a cookie with an invalid value is present (e.g., containing invalid URI sequences), `Astro.cookies.get()` now returns the raw cookie value instead of throwing a URIError. This aligns with the behavior of the underlying `cookie` package and prevents crashes when manually-set or corrupted cookies are encountered.

- [#&#8203;14142](withastro/astro#14142) [`73c5de9`](withastro/astro@73c5de9) Thanks [@&#8203;P4tt4te](https://github.com/P4tt4te)! - Updates handling of CSS for hydrated client components to prevent duplicates

- [#&#8203;14576](withastro/astro#14576) [`2af62c6`](withastro/astro@2af62c6) Thanks [@&#8203;aprici7y](https://github.com/aprici7y)! - Fixes a regression that caused `Astro.site` to always be `undefined` in `getStaticPaths()`

</details>

<details>
<summary>googleapis/google-api-nodejs-client (googleapis)</summary>

### [`v164.1.0`](https://github.com/googleapis/google-api-nodejs-client/blob/HEAD/CHANGELOG.md#16410-2025-10-20)

[Compare Source](googleapis/google-api-nodejs-client@googleapis-v164.0.0...googleapis-v164.1.0)

##### Features

- run the generator ([#&#8203;3820](googleapis/google-api-nodejs-client#3820)) ([fd02f58](googleapis/google-api-nodejs-client@fd02f58))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45OS4xMSIsInVwZGF0ZWRJblZlciI6IjQxLjk5LjExIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://code.richardbanks.dev/richard/astro-loader-youtube/pulls/22
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Astro.site no longer available in getStaticPaths()

2 participants