-
-
Couldn't load subscription status.
- Fork 2.9k
fix(svelte): async warning #14526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(svelte): async warning #14526
Conversation
🦋 Changeset detectedLatest commit: 89c60ce The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine as a workaround, but I think this should really be fixed in Svelte.
|
I'll open an issue upstream |
|
I wonder if @elliott-with-the-longest-name-on-github has any ideas for how to do this more cleanly |
|
Hmm, let me forward this to the team -- maybe we can expose it somehow... |
|
Thank you! |
|
@florian-lefebvre fixed upstream! You should be able to close this PR -- all that's necessary for users is to make sure they upgrade Svelte |
|
Thanks! |
Changes
renderwhencompilerOptions.experimental.asyncis not enabledrenderwas a promise to await it conditionnally, but that doesn't work because of how it's implemented in svelte: https://github.com/sveltejs/svelte/blob/main/packages/svelte/src/internal/server/renderer.js#L352-L384.thenis always presentcompilerOptions.experimental.async. I don't see a better fix without a change in svelte itselfTesting
Manual and tests added
Docs
Changeset