feat(astro): add copy button for stack trace in error overlay#14489
feat(astro): add copy button for stack trace in error overlay#14489matthewp merged 8 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 22b180d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #14489 will not alter performanceComparing Summary
Footnotes |
florian-lefebvre
left a comment
There was a problem hiding this comment.
Looks pretty good! Do you think you could add an e2e test for it?
|
Thanks for the review! Never wrote e2e tests, but a good opportunity to learn. Will add it. |
|
@florian-lefebvre, added e2e test to check the copy functionality, and also the button interaction Video showing the e2e testScreen.Recording.2025-10-07.at.12.38.17.AM.movAll the tests are passing |
|
Thanks for the review! @florian-lefebvre made the test case use |
|
Thanks looks good! We may be slow to merge it as we're currently at ViteConf |
|
Sure, no problem. Enjoy your time there! |
Princesseuh
left a comment
There was a problem hiding this comment.
Looks great, awesome work!
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
sarah11918
left a comment
There was a problem hiding this comment.
Changeset approved by docs! 🎉
|
@florian-lefebvre are we good to merge this? ^^ |
|
Yes! It's going to be part of 5.15, to be merged in the coming days |
|
Awesome! Thanks 🙌🏻 |

Changes
Video of the Implementation
Screen.Recording.2025-10-04.at.2.14.21.PM.mov
Testing
I ran
pnpm test:e2e:match "error|overlay", all the 18 test cases passedTest case screenshot
Docs
It is a small UI addition to the error overlay, so i believe no docs are needed