Skip to content

feat: update vite #14445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 29, 2025
Merged

feat: update vite #14445

merged 6 commits into from
Sep 29, 2025

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Sep 26, 2025 •
edited
Loading

Changes

Testing

Should pass

Docs

withastro/docs#12444

@florian-lefebvre florian-lefebvre added this to the v6.0.0 milestone Sep 26, 2025
@florian-lefebvre florian-lefebvre self-assigned this Sep 26, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7f48560

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Sep 26, 2025
@florian-lefebvre florian-lefebvre mentioned this pull request Sep 26, 2025
Merged
@florian-lefebvre florian-lefebvre marked this pull request as ready for review September 26, 2025 13:08
@github-actions github-actions bot added the semver: major Change triggers a `major` release label Sep 26, 2025
github-actions[bot]
github-actions bot requested changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@florian-lefebvre
Copy link
Member Author

Looks like some changes were made around errors tho

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025 •
edited
Loading

📝 Changeset Validation Results

❌ Changeset validation failed

Issues Found:

.changeset/tricky-donkeys-camp.md

Issue with: '#### What should I do?'

❌ The usage of a '####' heading style is prohibited based on the guidelines.

💡 Consider altering the heading style to normal text or using a lower-impact format.

📖 See Astro's changeset guide for details.

yanthomasdev
yanthomasdev reviewed Sep 29, 2025
View reviewed changes
sarah11918
sarah11918 approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, Yan! Changeset LGTM!

@florian-lefebvre florian-lefebvre merged commit ecb0b98 into next Sep 29, 2025
18 of 19 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/vite-7 branch September 29, 2025 14:27
ematipico pushed a commit that referenced this pull request Oct 14, 2025
@florian-lefebvre @yanthomasdev @ematipico
feat: update vite (#14445)
219d79e 
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanthomasdev yanthomasdev yanthomasdev left review comments

@github-actions github-actions[bot] github-actions[bot] requested changes

@ascorbic ascorbic ascorbic approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

@florian-lefebvre florian-lefebvre

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) semver: major Change triggers a `major` release

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@florian-lefebvre @ascorbic @sarah11918 @yanthomasdev