-
-
Notifications
You must be signed in to change notification settings - Fork 3k
feat: deprecate Astro in getStaticPaths #14432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate Astro in getStaticPaths #14432
Conversation
🦋 Changeset detectedLatest commit: e5ee687 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.
| # Wait until three days after release to install new versions of packages | ||
| minimumReleaseAge: 4320 | ||
| # TODO: uncomment before merging into main | ||
| # minimumReleaseAge: 4320 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was preventing pnpm from using the preview release so I disabled it. I added a task on the Astro 6 project to remember to re-enable it later
|
@sarah11918 there's the changeset and a new error to review whenever you have time! |
Co-authored-by: Yan <[email protected]>
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset looks great! Had a comment about the error message for you to consider!
Co-authored-by: Sarah Rainsberger <[email protected]>
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Changes
AstroingetStaticPaths#14372Astro.siteorAstro.generatoringetStaticPathswill log a warningAstroproperty ingetStaticPathswill throw an errorTesting
Integration tests added.
Docs
withastro/docs#12435 + changeset