- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.9k
feat!: clean up internal symbols usage #14420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
 | 
| @sarah11918 let me know if you think this needs docs but I don't think it does! | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to match cloudflare
| I think this all seems pretty internal, if it's only official adapters (so, integration authors don't need to know/do anything different?) and it's otherwise internal code (so, no Astro project code needs to change.) So, I'll still want to review the changeset in the end, but likely no docs seems like the right call! | 
| Since it should only be a refactor, I'm thinking about not including a changeset at all | 
Changes
astro.localssymbol is only used in dev by official adapters, so it can be removed from hereastro.clientAddresssymbol is meant to be used internally only, now thatclientAddresscan be passed toapp.render()Testing
Should still pass
Docs
Shouldn't be needed as it's an undocumented API