feat(astro)!: update i18n.redirectToDefaultLocale default
#14406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5ae77cf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| type RunHookBuildDone = { | ||
| settings: AstroSettings; | ||
| pages: string[]; | ||
| // TODO: remove in Astro 6 |
There was a problem hiding this comment.
We forgot to add this todo while doing https://docs.astro.build/en/guides/upgrade-to/v5/#deprecated-routes-on-astrobuilddone-hook-integration-api
sarah11918
reviewed
Sep 24, 2025
Co-authored-by: Sarah Rainsberger <[email protected]>
ascorbic
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
i18n.routing.redirectToDefaultLocalefromtruetofalse, becomes by default in v5 it may cause an infinite loop. Found in feat: move astro config validation after astro:config:setup #13482, temporarily fixed in fix(i18n): incorrect validation #13552Testing
Updated, should pass
Docs
withastro/docs#12353, changeset TBD