add cloudflare workers static assets example

[alexanderniebuhr]

Changes

• this pr adds a new example which has the "minimal" setup needed for Cloudflare Workers Static Assets deployment
• it does not include all the features or advanced Cloudflare usages

Testing

• pnpm create astro@latest -- --template cloudflare-workers-static-assets

Docs

Not really needed, since custom examples are already documented here: https://docs.astro.build/en/install-and-setup/#use-a-theme-or-starter-template

@sarah11918 we could discuss if we want to add this command pnpm create astro@latest -- --template cloudflare-workers-static-assets to the Cloudflare docs page itself?

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4cacb14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[sarah11918]

Re: adding the template instructions to the Cloudflare adapter page, we don't really have a precedent for that yet!

I'd probably be more inclined to consider it if this is basic setup that every Cloudflare user wants/needs. If this is an example of one specific thing that you might want to do with Cloudflare, then maybe less inclined. It's also thinking of who is in docs and when: if someone is mostly reading these docs to work on already existing projects, then the example is maybe a little less helpful for them at this point? (It could be helpful as a model for them to look at to see how it's done. But since these are typically fresh projects we mostly consider pointing people to them when we believe they are in a "getting started with a new project" state.)

But it does raise maybe a bigger question re: should we be pointing out these examples that we have in appropriate places in docs.

Also, I'm not sure what (if anything!) we need to add to this to get it to show up on https://astro.new in the right category (I guess we would consider this a "Template"?) so just making sure that you've done whatever is needed there, too! I think this is where the logic in that repo is: https://github.com/withastro/astro.new/blob/main/src/data/examples-shared.ts

[Fryuni]

It seems the only thing cloudflare-specific on this is the adapter and the wrangler.jsonc. Is a full example needed for that?

We don't have an example for every adapter and their features. If this wrangler.jsonc is the minimum requirement for Cloudflare perhaps we could just generate it on astro add cloudflare like we do for Tailwind stuff.

I'm not against it, just seems like it would be best as codemod or as a recipe in Docs

[alexanderniebuhr]

@Fryuni totally agree. I remember @delucis told me in the past that it is not easy to add logic to ˋastro addˋ but if we can do that, I would prefer that way too. This example is just my workaround to help users get everything they need to run on Cloudflare without the need to manually create files.

[delucis]

Could you also PR here to skip the new example? https://github.com/withastro/preview.astro.new/blob/a8ef039271a9d889579610c826d87141c54006ba/src/build.mjs#L32

Those will build on Netlify as static sites so we can't deploy SSR examples.

[delucis]

@Fryuni totally agree. I remember @delucis told me in the past that it is not easy to add logic to ˋastro addˋ but if we can do that, I would prefer that way too. This example is just my workaround to help users get everything they need to run on Cloudflare without the need to manually create files.

Missed this when sharing a quick review previously, sorry. It’s not possible for third-party integrations, but should be do-able for the Cloudflare one potentially. You could check how we handle astro add tailwind.

[florian-lefebvre]

So what's the status of this PR? Looks like it shouldn't be an example but rather an update to astro add?

[Fryuni]

So what's the status of this PR? Looks like it shouldn't be an example but rather an update to astro add?

That would be the best option IMO. This way users can use any of the existing templates that better fits their use case along with astro add cloudflare.

[florian-lefebvre]

See #14564

[delucis]

Nice! Thanks @florian-lefebvre. I guess we can close this one then.