Skip to content

Conversation

@alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented Jul 11, 2025

Changes

Testing

  • tests should still pass
  • now new test is needed

Docs

  • not needed bugfix

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2025

🦋 Changeset detected

Latest commit: 7ed642f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexanderniebuhr alexanderniebuhr force-pushed the alexanderniebuhr/astro-session-cf-kv-locally branch from 9dd4c78 to d925b1b Compare July 31, 2025 07:33
Co-authored-by: Matt Kane <m@mk.gg>
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@ascorbic
Copy link
Contributor

ascorbic commented Aug 8, 2025

@alexanderniebuhr can this be merged?

@ascorbic ascorbic added this to the v5.13.0 milestone Aug 8, 2025
@ascorbic
Copy link
Contributor

ascorbic commented Aug 8, 2025

Added to the 5.13 milestone so it's mentioned in the blog

@alexanderniebuhr
Copy link
Member Author

It can yes!

@ascorbic ascorbic merged commit 7abde79 into main Aug 8, 2025
14 checks passed
@ascorbic ascorbic deleted the alexanderniebuhr/astro-session-cf-kv-locally branch August 8, 2025 11:51
@ascorbic
Copy link
Contributor

ascorbic commented Aug 8, 2025

If your PR is ready and approved you can always just merge it!

@astrobot-houston astrobot-houston mentioned this pull request Aug 8, 2025
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
* refactor astro sessions to use cf kv binding

* refactor: hoist up session kv binding name

* chore: add changeset

* chore: resolve PR comments

Co-authored-by: Matt Kane <m@mk.gg>

* chore: resolve PR comments

Co-authored-by: Matt Kane <m@mk.gg>

* chore: update changeset

---------

Co-authored-by: Matt Kane <m@mk.gg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Cloudflare sessions in dev with platformProxy

5 participants