Skip to content

feat(node): experimentalDisableStreaming#14012

Merged
ematipico merged 15 commits intomainfrom
test/node-streaming-false
Jul 2, 2025
Merged

feat(node): experimentalDisableStreaming#14012
ematipico merged 15 commits intomainfrom
test/node-streaming-false

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Jun 24, 2025

Changes

Testing

Manually

Docs

Changeset + withastro/docs#11947

@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2025

🦋 Changeset detected

Latest commit: b3def51

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@florian-lefebvre florian-lefebvre added the pr preview Apply this label to a PR to generate a preview release label Jun 24, 2025
@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) and removed pr preview Apply this label to a PR to generate a preview release labels Jun 24, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 24, 2025

astro

npm i https://pkg.pr.new/astro@14012

@astrojs/cloudflare

npm i https://pkg.pr.new/@astrojs/cloudflare@14012

@astrojs/netlify

npm i https://pkg.pr.new/@astrojs/netlify@14012

@astrojs/node

npm i https://pkg.pr.new/@astrojs/node@14012

@astrojs/vercel

npm i https://pkg.pr.new/@astrojs/vercel@14012

commit: a37b281

@florian-lefebvre florian-lefebvre added the pr preview Apply this label to a PR to generate a preview release label Jun 24, 2025
@github-actions github-actions bot removed the pr preview Apply this label to a PR to generate a preview release label Jun 24, 2025
@florian-lefebvre florian-lefebvre changed the title test: node streaming false feat(node): experimentalDisableStreaming Jun 24, 2025
@florian-lefebvre florian-lefebvre self-assigned this Jun 24, 2025
@florian-lefebvre florian-lefebvre marked this pull request as ready for review June 24, 2025 15:21
@ascorbic
Copy link
Contributor

Is it possible to add tests? It would be good to e.g. check that the right headers are set

@florian-lefebvre
Copy link
Member Author

@ascorbic tests added!

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we could suggest specific use cases for this new feature

@florian-lefebvre florian-lefebvre added this to the v5.11.0 milestone Jun 30, 2025
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Just a couple of notes re: shaping this for the changelog vs being a reference definition! 🙌

florian-lefebvre and others added 2 commits July 2, 2025 08:12
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
@ematipico ematipico merged commit a125a14 into main Jul 2, 2025
13 of 14 checks passed
@ematipico ematipico deleted the test/node-streaming-false branch July 2, 2025 14:01
@astrobot-houston astrobot-houston mentioned this pull request Jul 2, 2025
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>


Co-authored-by: ascorbic <213306+ascorbic@users.noreply.github.com>
Co-authored-by: ematipico <602478+ematipico@users.noreply.github.com>
Co-authored-by: sarah11918 <5098874+sarah11918@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants