Skip to content

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented May 28, 2025

Changes

  • Closes ERROR toolbar #13841
  • A browser extension could block a script we inject, breaking the devtoolbar
  • This PR handles the case where __astro_dev_toolbar__ is not set

Testing

N/A. Couldn't get the user to test it

Docs

Changeset

@florian-lefebvre florian-lefebvre self-assigned this May 28, 2025
@changeset-bot
Copy link

changeset-bot bot commented May 28, 2025

🦋 Changeset detected

Latest commit: e7d2d95

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 28, 2025
@florian-lefebvre florian-lefebvre added pr preview Apply this label to a PR to generate a preview release and removed pkg: astro Related to the core `astro` package (scope) labels May 28, 2025
@github-actions github-actions bot removed the pr preview Apply this label to a PR to generate a preview release label May 28, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented May 28, 2025

astro

npm i https://pkg.pr.new/astro@13862

@astrojs/cloudflare

npm i https://pkg.pr.new/@astrojs/cloudflare@13862

@astrojs/netlify

npm i https://pkg.pr.new/@astrojs/netlify@13862

@astrojs/node

npm i https://pkg.pr.new/@astrojs/node@13862

@astrojs/vercel

npm i https://pkg.pr.new/@astrojs/vercel@13862

commit: e7d2d95

@codspeed-hq
Copy link

codspeed-hq bot commented May 28, 2025

CodSpeed Performance Report

Merging #13862 will not alter performance

Comparing fix/devtoolbar-data-unset (e7d2d95) with main (de2fc9b)

Summary

✅ 6 untouched benchmarks

@florian-lefebvre florian-lefebvre marked this pull request as ready for review June 5, 2025 13:55
@florian-lefebvre florian-lefebvre merged commit fe8f61a into main Jun 17, 2025
18 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/devtoolbar-data-unset branch June 17, 2025 09:39
@astrobot-houston astrobot-houston mentioned this pull request Jun 17, 2025
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR toolbar

2 participants