Skip to content

fix(types): add server.allowedHosts docs comment to AstroUserConfig#13660

Merged
ematipico merged 2 commits intomainfrom
fix/add-server-allowed-hosts-docs-comment-to-astro-user-config
Apr 22, 2025
Merged

fix(types): add server.allowedHosts docs comment to AstroUserConfig#13660
ematipico merged 2 commits intomainfrom
fix/add-server-allowed-hosts-docs-comment-to-astro-user-config

Conversation

@mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Apr 20, 2025

Changes

  • This PR adds server.allowedHosts docs comment to AstroUserConfig

Testing

  • N/A

Docs

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2025

🦋 Changeset detected

Latest commit: 0af7f6d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Apr 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 20, 2025

CodSpeed Performance Report

Merging #13660 will not alter performance

Comparing fix/add-server-allowed-hosts-docs-comment-to-astro-user-config (0af7f6d) with main (d75cac4)

Summary

✅ 6 untouched benchmarks

sarah11918
sarah11918 approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs! Thank you @mingjunlu 🚀

ematipico
ematipico approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarah11918 how about having a README.md that explains how to author new configuration fields?

@ematipico ematipico merged commit 620d15d into main Apr 22, 2025
17 checks passed
@ematipico ematipico deleted the fix/add-server-allowed-hosts-docs-comment-to-astro-user-config branch April 22, 2025 09:20
@astrobot-houston astrobot-houston mentioned this pull request Apr 22, 2025
Merged
@sarah11918
Copy link
Member

sarah11918 commented Apr 22, 2025

@ematipico Great idea! Would you be willing to make a docs discussion with content you think would be helpful to have there? https://github.com/withastro/docs/discussions/

openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
@mingjunlu @openscript
fix(types): add server.allowedHosts docs comment to `AstroUserConfi…
587eaeb 
…g` (withastro#13660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

server.allowedHosts not documented in the config reference

3 participants

@mingjunlu @sarah11918 @ematipico