Fix build errors being ignored when using concurrency#13566
Merged
florian-lefebvre merged 1 commit intomainfrom May 13, 2025
Merged
Fix build errors being ignored when using concurrency#13566florian-lefebvre merged 1 commit intomainfrom
florian-lefebvre merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: ee63074 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
1 task
CodSpeed Performance ReportMerging #13566 will not alter performanceComparing Summary
|
florian-lefebvre
approved these changes
May 13, 2025
Merged
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix build errors being ignored when using concurrency, by using
Promise.allinstead ofPromise.allSettledTesting
Added a test fixture that throws an error when built.
Docs
N/A (expected behaviour)