Version transitions in CLI outputs#12739
Merged
florian-lefebvre merged 5 commits intowithastro:mainfrom Jan 10, 2025
outslept:idkgene/upgrade-package
Merged
Version transitions in CLI outputs#12739florian-lefebvre merged 5 commits intowithastro:mainfrom outslept:idkgene/upgrade-package
florian-lefebvre merged 5 commits intowithastro:mainfrom
outslept:idkgene/upgrade-package
Conversation
- Updated the upgrade function to include the current version in the upgrade message format. - Modified test assertions to reflect the new message format. Background & Motivation: The current output format lacks clarity in showing version changes. Adding a simple 'from → to' format improves visibility and developer experience when updating Astro packages. Before: @astrojs/tailwind can be updated to v5.1.3 After: @astrojs/tailwind can be updated v4.0.0 → v5.1.3 This change: - Makes the upgrade process "more transparent" - Simplifies version change tracking - Improves DX during updates See withastro/roadmap#1069
🦋 Changeset detectedLatest commit: 0692110 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
This is opinionated, I am open to any adjustments |
- Remove 'to' particle from update messages - Adjusted spacing in version comparison output - Update tests to match the spacing Before: ▲ astro can be updated to v1.0.0 → v2.0.0 After: ▲ astro can be updated v1.0.0 → v2.0.0
Member
|
Last thing, can you add a patch changeset? Running |
Contributor
Author
Completely forgot about that. Done |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Before:
After:
Testing
Updated existing test suite by modifying test assertions to verify new message format
Docs
Should be self-explanatory
Additional
Coming from withastro/roadmap#1069