fix: add support for react-compiler-runtime

[stipsan]

Changes

Adds support for libraries publishing code pre-compiled with the React Compiler

Testing

Don't know enough about astro internals to add a test 🤷

Docs

Don't think docs need to change, support for react-compiler-runtime is just expected to work, same way the react/jsx-runtime is.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0764e5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[matthewp]

lgtm, waiting for confirmation from the Sanity team that this fixes the bug they are experiencing.

[matthewp]

They were able to confirm. Thanks again!

[matthewp]

I forgot to add a changeset here, so I did so here instead: #12755

[ascorbic]

Unfortunately this is logging a warning for users who don't have react-compiler-runtime installed (so most people). It would be great if we could conditionally include it or suppress the warnign somehow. #12896

[bluwy]

Is there an example library or repro that uses react-compiler-runtime and requires this config? Vite should be able to optimize it beforehand and doesn't need to be manually specified.

[ascorbic]

There are some Sanity libraries listed here that need it.

[stipsan]

Is there an example library or repro that uses react-compiler-runtime and requires this config? Vite should be able to optimize it beforehand and doesn't need to be manually specified.

That's true in general, but this is a special case similar to react/jsx-runtime, where the imports are added during a compile step, and while the library is ESM, the react published packages are still CJS. If Vite always optimizes these deps correctly, then we wouldn't need to have these in the list either

astro/packages/integrations/react/src/index.ts

Line 60 in 88b493c

'react/jsx-runtime',

[bluwy]

In your PR description you mentioned "libraries publishing code pre-compiled with the React Compiler", so isn't react-compiler-runtime already visible before compilation by the consumer? Vite should already be handling this correctly by default, even with CJS.

And if any change needs to be made, it should be in @vitejs/plugin-react, which it already has handling for the react compiler: https://github.com/vitejs/vite-plugin-react/blob/ab12dfafbab3260bfd4904d85375ea2c02c36afe/packages/plugin-react/src/index.ts#L282-L296. The optimizeDeps.include list we have is an artifact for when we didn't use @vitejs/plugin-react before. Now we could remove if we want to.