Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align esbuild to vite #12361

Merged
merged 5 commits into from
Jan 13, 2025
Merged

fix: align esbuild to vite #12361

merged 5 commits into from
Jan 13, 2025

Conversation

LunaticMuch
Copy link
Contributor

Fixes #12360

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release labels Nov 2, 2024
github-actions[bot]
github-actions bot previously requested changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e516719

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) labels Jan 10, 2025
bluwy
bluwy approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're now using Vite 6 so we can align esbuild again

@bluwy bluwy dismissed github-actions[bot]’s stale review January 10, 2025 15:48

this is more of a patch than a minor

@bluwy bluwy removed the semver: minor Change triggers a `minor` release label Jan 10, 2025
@bluwy bluwy merged commit 3d89e62 into withastro:main Jan 13, 2025
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Esbuild 0.21.5 uses binaries which contains known vulnerabilities
2 participants
@LunaticMuch @bluwy