feat(hybrid): Clean logging and misc tweaks for hybrid removal #11942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
pkg: astro
Member
Author
|
The changesets for this PR are here #11941 |
Princesseuh
commented
Sep 7, 2024
| * | ||
| * To get the user's IP address in static mode, different APIs such as [Ipify](https://www.ipify.org/) can be used in a [Client-side script](https://docs.astro.build/en/guides/client-side-scripts/) or it may be possible to get the user's IP using a serverless function hosted on your hosting provider. | ||
| */ | ||
| export const StaticClientAddressNotAvailable = { |
Member
Author
There was a problem hiding this comment.
This message can show in middleware code, I'm not exactly sure why though.
matthewp
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR tackles the rest of the owl, this change
forceServerOutputto a more genericbuildOutputthat allow adapters to set themselves as being for static websites, some logging wasn't working correctly after the removal of hybrid and in some cases, the logging was missing.Testing
Tests should pass!
Docs
Some of it is docs! There's errors!