Support import astro components with vite queries #11478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 98922d2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Princesseuh
reviewed
Jul 17, 2024
| @@ -50,3 +50,12 @@ const postfixRE = /[?#].*$/s; | |||
| export function cleanUrl(url: string): string { | |||
| return url.replace(postfixRE, ''); | |||
| } | |||
|
|
|||
| const specialQueriesRE = /(?:\?|&)(?:url|raw|direct)(?:&|$)/; | |||
There was a problem hiding this comment.
It'd be great if Vite exposed a blessed way to do this, I've had this usecase before
There was a problem hiding this comment.
Yeah perhaps it could. It already exposes APIs like isCSSRequest
Princesseuh
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fix #11410
In the
transformhook, if theidhas Vite special queries, we skip transforming it, because the code will already be in JS when Vite handles theload().Testing
Added test
Docs
n/a. bug fix.