-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(container): provide a virtual module to load renderers #11144
Conversation
🦋 Changeset detectedLatest commit: 7a59701 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview container |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
!preview container |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
!preview container |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
!preview container |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
!preview container |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
@ematipico demo works now. |
8952c85
to
bde2823
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ematipico ! Some quick changeset suggestions for your consideration!
319a4e8
to
d23e386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fixed a spacing issue, and approving for docs!
Co-authored-by: Sarah Rainsberger <[email protected]>
c037552
to
7a59701
Compare
Changes
This PR does the following:
getContainerRenderer
. This function will be used by the consumers of a vite-full environmentastro:container
, that exposes a utility function that loads the renderers when people are in a vite-full environmentrenderers
; this change should allow vite-less environments to load the renderer modules manually and pass themTesting
I updated the example with the new code
Docs
/cc @withastro/maintainers-docs for feedback!
We will probably need to update the docs for that
withastro/docs#8428