Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated APIs from @astrojs/markdown-remark #10629

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 1, 2024

Changes

  1. Remove remarkShiki and remarkPrism (deprecated)
  2. Remove replaceCssVariables (internal utils that no longer used)
  3. Remove unused types. They're still exported from astro, so to preserve compat I moved the types to @types/astro.ts and marked them deprecated.
  4. Some unused types are also from Improve markdown rendering performance #8532 which I forgot to remove.

This PR is a major for @astrojs/markdown-remark and will go in hand with #10618

Testing

Existing tests should pass.

Docs

Added a changeset. Otherwise most Astro users shouldn't notice this change

Copy link

changeset-bot bot commented Apr 1, 2024

🦋 Changeset detected

Latest commit: b3087fd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Apr 1, 2024
@bluwy bluwy changed the title Remove deprecated APIs Remove deprecated APIs from @astrojs/markdown-remark Apr 1, 2024
Co-authored-by: Florian Lefebvre <[email protected]>
@bluwy bluwy merged commit 2cf116f into main Apr 1, 2024
14 checks passed
@bluwy bluwy deleted the markdown-remark-major branch April 1, 2024 14:53
@astrobot-houston astrobot-houston mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants