Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use biome to sort imports - only test files #10180

Merged
merged 3 commits into from
Feb 21, 2024
Merged

chore: use biome to sort imports - only test files #10180

merged 3 commits into from
Feb 21, 2024

Conversation

ematipico
Copy link
Member

Changes

That's how I would like to start introducing Biome in the repository.

Import sorting of the test files. They should not change the logic of the source code.

Testing

CI should work.

After merging this PR, I will make a new PR to ignore the commit from git.

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 87b0f69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) labels Feb 21, 2024
bluwy
bluwy approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this start! Better to merge it as soon as possible to prevent conflicts. I only have one (optional) comment below.

package.json Outdated Show resolved Hide resolved
@ematipico @bluwy
Update package.json
87b0f69 
Co-authored-by: Bjorn Lu <[email protected]>
@ematipico ematipico merged commit 0626234 into main Feb 21, 2024
4 checks passed
@ematipico ematipico deleted the chore/import-sorting-tests-biome branch February 21, 2024 14:08
This was referenced Feb 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: react Related to React (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ematipico @bluwy