Fix invalid URLs being returned from getRegistry
, synchronize all copies of the function
#10117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getRegistry
functions used in our CLI toolscreate astro
,astro add
and@astrojs/upgrade
assumed that the output of the CLI command<package manager> config get registry
would always be a URL. However, in the reported case, the command output started with a warning message, which was then returned bygetRegistry
without further validation, causing all dependent functionality to fail in unexpected ways.host
. In both cases, our existing fallback URLhttps://registry.npmjs.org
will now be used.create-astro
now, which could speed up the other CLI commands. In the future, we should investigate if we can actually use the same function from all tools instead of keeping 3 copies.Testing
Docs