feat(audits): Add initial perf audits #10015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bfdf79b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
🚨 action
⚖️ Bundle Size CheckLatest commit: bfdf79b
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Princesseuh
commented
Feb 8, 2024
Comment on lines
182
to
184
| const hydrator = this.hydrator(this); | ||
| if (process.env.NODE_ENV === 'development') hydrationTimeStart = performance.now(); | ||
| await this.hydrator(this)(this.Component, props, slots, { | ||
| await hydrator(this.Component, props, slots, { |
There was a problem hiding this comment.
I'm not sure if this actually does something, but when testing locally, I was getting times that made a bit more sense and were generally more stable 🤷♀️
bluwy
reviewed
Feb 8, 2024
Co-authored-by: Bjorn Lu <[email protected]>
bluwy
reviewed
Feb 8, 2024
packages/astro/e2e/fixtures/dev-toolbar/src/pages/audits-perf.astro
Outdated
Show resolved
Hide resolved
ematipico
reviewed
Feb 12, 2024
packages/astro/src/runtime/client/dev-toolbar/apps/audit/perf.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-toolbar/apps/audit/perf.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-toolbar/apps/audit/perf.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+62
to
+64
| title: 'Use videos instead of GIFs for large animations', | ||
| message: | ||
| 'This GIF could be replaced with a video to reduce its file size and improve performance.', |
There was a problem hiding this comment.
We should tell the user what "large" means, maybe by explicitly tell the user what's the threshold of this audit
packages/astro/src/runtime/client/dev-toolbar/apps/audit/perf.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-toolbar/apps/audit/perf.ts
Outdated
Show resolved
Hide resolved
sarah11918
approved these changes
Feb 13, 2024
ematipico
approved these changes
Feb 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a beginning of perf audits and infrastructure for it, most notably, this includes a
server-render-timeandclient-render-timeattribute on islands, allowing us to provide audits when an island take a suspicious amount of time to render.Testing
Added some tests!
Docs
N/A