-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine content collection warnings #10001
Conversation
🦋 Changeset detectedLatest commit: 9d34d66 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super familiar with the type gen code, but I agree with the idea here and it looks like the right pieces have been added and removed as far as I can tell — thanks for tackling @bholmesdev!
Co-authored-by: Chris Swithinbank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAY BEN! 🥳
For the sake of a visible checkmark, docs is approving!
Changes
Starlight users have struggled with a warning message for the
i18n
collection:This warning was initially added to prevent typos between your configured collection name and the actual directory name. Even so, warning logs are easily lost during development. This GitHub discussion describes hours lost due to this.
What we want is some indicator during development that there's a mismatch, without excessive console warnings. We landed here:
article
andarticles
in my intellisense? Ah, probably a typo."Code changes
Testing
N/A - type change only
Docs
N/A