Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update adapters supported features to account for new shape for Astro 5 #392

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

Princesseuh
Copy link
Member

Changes

In Astro 5, the section on assets has been removed from supportedAstroFeatures because it made no sense, you cannot not support "assets" as a concept, otherwise your adapter either can't have routes (it doesn't support having an endpoint), or does not support hosting assets in general (so you don't support any imports that results in a file, no JS, no CSS, no images etc)

In truth, adapters always support astro:assets the feature, what they don't support is the default image service that relies on Node API at runtime. As such, options we updated to reflect only that.

Testing

N/A

Docs

N/A

Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 96c75e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 52 packages
Name Type
@astrojs/cloudflare Major
@astrojs/netlify Major
@astrojs/vercel Major
@astrojs/node Major
@test/astro-cloudflare-astro-dev-platform Patch
@test/astro-cloudflare-astro-env Patch
@test/astro-cloudflare-compile-image-service Patch
@test/astro-cloudflare-external-image-service Patch
@test/astro-cloudflare-wasm Patch
@test/astro-cloudflare-no-output Patch
@test/astro-cloudflare-routes-json Patch
@test/astro-cloudflare-with-solid-js Patch
@test/astro-cloudflare-wrangler-preview-platform Patch
@test/netlify-cookies Patch
@test/netlify-middleware-without-handler-file Patch
@test/netlify-redirects Patch
@test/netlify-hosted-astro-project Patch
@test/netlify-static-redirects Patch
@test/astro-vercel-basic Patch
@test/astro-vercel-image Patch
@test/vercel-isr Patch
@test/vercel-max-duration Patch
@test/vercel-edge-middleware-with-edge-file Patch
@test/vercel-edge-middleware-without-edge-file Patch
@test/astro-vercel-no-output Patch
@test/astro-vercel-prerendered-error-pages Patch
@test/astro-vercel-redirects-serverless Patch
@test/astro-vercel-redirects Patch
@test/vercel-server-islands Patch
@test/astro-vercel-serverless-prerender Patch
@test/astro-vercel-serverless-with-dynamic-routes Patch
@test/astro-vercel-static-assets Patch
@test/astro-vercel-static Patch
@test/vercel-streaming Patch
@test/astro-vercel-with-speed-insights-enabled-output-as-server Patch
@test/astro-vercel-with-speed-insights-enabled-output-as-static Patch
@test/astro-vercel-with-web-analytics-enabled-output-as-static Patch
vercel-hosted-astro-project Patch
@test/nodejs-api-route Patch
@test/nodejs-badurls Patch
@test/nodejs-encoded Patch
@test/nodejs-errors Patch
@test/nodejs-headers Patch
@test/nodejs-image Patch
@test/locals Patch
@test/node-middleware Patch
@test/nodejs-prerender-404-500 Patch
@test/nodejs-prerender Patch
@test/nodejs-preview-headers Patch
@test/node-trailingslash Patch
@test/url Patch
@test/well-known-locations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -455,12 +455,7 @@ export default function netlifyIntegration(
hybridOutput: 'stable',
staticOutput: 'stable',
serverOutput: 'stable',
assets: {
// keeping this as experimental at least until Netlify Image CDN is out of beta
supportKind: 'experimental',
Copy link
Member Author

@Princesseuh Princesseuh Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes no sense for Netlify to use this to reflect the Image CDN service being experimental. This leads to a wonky spooky messages for users (assets are not supported, what does that mean?)

I just updated it to match the new config, but a warning could be added separately from this (using the adapter config to check if the image cdn is enabled)

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we need a changeset?

@Princesseuh Princesseuh merged commit 3a49eb7 into next Sep 13, 2024
1 of 3 checks passed
@github-actions github-actions bot mentioned this pull request Sep 16, 2024
This was referenced Sep 23, 2024
This was referenced Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants