Skip to content
This repository has been archived by the owner on Feb 10, 2025. It is now read-only.

fix(cloudflare): Fixes peer dependency conflict #344

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

Fryuni
Copy link
Member

@Fryuni Fryuni commented Aug 4, 2024

Changes

@inox-tools/astro-when 0.2.0 has a peer dependency requirement on Astro ^4.12.2 while the Cloudflare adapter has a peer dependency on ^4.10. This could cause issues for people trying to update the adapter with Astro version 4.10.x and 4.11.x.

Astro When doesn't require anything from 4.12; it had that requirement just by using the same as all other Inox Tools. I released version 0.2.1 with the restriction relaxed to ^4. Since the dependency on Astro When is ^0.2.0 consumer projects will already get the update, but I think it is safer to enforce the minimal correct version on the dependency.

@Fryuni Fryuni added pkg: cloudflare - P2: has workaround Bug, but has workaround (priority) labels Aug 4, 2024
@Fryuni Fryuni requested a review from alexanderniebuhr August 4, 2024 05:04
@Fryuni Fryuni self-assigned this Aug 4, 2024
Copy link

changeset-bot bot commented Aug 4, 2024

🦋 Changeset detected

Latest commit: 6741207

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@astrojs/cloudflare Patch
@test/astro-cloudflare-astro-dev-platform Patch
@test/astro-cloudflare-astro-env Patch
@test/astro-cloudflare-compile-image-service Patch
@test/astro-cloudflare-external-image-service Patch
@test/astro-cloudflare-wasm Patch
@test/astro-cloudflare-no-output Patch
@test/astro-cloudflare-routes-json Patch
@test/astro-cloudflare-with-solid-js Patch
@test/astro-cloudflare-wrangler-preview-platform Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Fryuni Fryuni changed the title Fix peer dependency conflict fix(cloudflare): Fixes peer dependency conflict Aug 4, 2024
@alexanderniebuhr alexanderniebuhr merged commit 8d7766e into main Aug 4, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Aug 4, 2024
@Fryuni Fryuni deleted the fix/update-astro-when branch August 4, 2024 06:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
- P2: has workaround Bug, but has workaround (priority) pkg: cloudflare
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants