fix(cloudflare): dynamic-imports-analyzer

[alexanderniebuhr]

Changes

• closes Build Fails with @astrojs/[email protected] #237

[changeset-bot]

🦋 Changeset detected

Latest commit: 22df2c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@astrojs/cloudflare	Patch
@test/astro-cloudflare-astro-dev-platform	Patch
@test/astro-cloudflare-external-image-service	Patch
@test/astro-cloudflare-no-output	Patch
@test/astro-cloudflare-prerender-optimizations	Patch
@test/astro-cloudflare-routes-json	Patch
@test/astro-cloudflare-wasm	Patch
@test/astro-cloudflare-with-solid-js	Patch
@test/astro-cloudflare-wrangler-preview-platform	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[matthewp]

It's up to you to make regex workarounds, just want to pass some caution that this could break if code changes in core, of course.

[alexanderniebuhr]

Totally valid, we'll need a workaround until core catches up, but I can make it based on AST, which is more robust!

[alexanderniebuhr]

!preview ast

[github-actions]

Snapshots have been released for the following packages:

• @astrojs/cloudflare@experimental--ast

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--ast tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info @astrojs/cloudflare
🦋  info npm info @astrojs/netlify
🦋  info @astrojs/cloudflare is being published because our local version (0.0.0-ast-20240419160649) has not been published on npm
🦋  warn @astrojs/netlify is not being published because version 5.2.0 is already published on npm
🦋  info Publishing "@astrojs/cloudflare" at "0.0.0-ast-20240419160649"
🦋  success packages published successfully:
🦋  @astrojs/[email protected]
🦋  Creating git tag...
🦋  New tag:  @astrojs/[email protected]

Build Log

> [email protected] build /home/runner/work/adapters/adapters
> turbo run build --filter="@astrojs/*"

• Packages in scope: @astrojs/cloudflare, @astrojs/netlify, @astrojs/test-utils
• Running build in 3 packages
• Remote caching disabled
::group::@astrojs/netlify:build
cache miss, executing f0ca439d5409f69e

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/netlify
> tsc

::endgroup::
::group::@astrojs/cloudflare:build
cache miss, executing 7281f16cac6c1bb3

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/cloudflare
> tsc

::endgroup::

 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    3.705s 

[Fryuni]

AST handling looks so much better than regex <3

Definitely gives me more confidence