docs: gsd-method revision 2 from the Blockvalley Phase 1 retro - #92
Merged
Merged
Conversation
withally
force-pushed
the
fm/fm-gsd-method-doc-r2
branch
from
August 30, 2026 13:16
aef8147 to
372e974
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Revise docs/gsd-method.md as revision 2 from section 3 of the Blockvalley Phase 1 retro. Fold in five concrete rules, each with a one-line why: a one-page phase-plan slice contract with bounded task and acceptance-criterion counts plus a mandatory deletion pass before CHECK; a signed kept/changed/parked scope-delta artifact acknowledged by every live worker; a code-level Don’t-Hand-Roll audit plus independent critic before local-main landing of a proof slice and never deferred; an on-phone capture manifest with element IDs, camera bounds, deterministic frame, and per-criterion evidence links; and check-in cost accounting for model, rounds, and wall time. Keep the existing provenance-tag, CONTEXT, Don’t-Hand-Roll, and plan-check structure without restyling it. Touch docs/gsd-method.md only unless a pointer is strictly needed, use one sentence per Markdown line and plain dashes, keep net growth under about 60 lines, copy nothing private, and cite the source only as Blockvalley Phase 1 retro. Validate with bin/fm-lint.sh and bin/fm-doc-audience-check.sh. Attest and update existing PR 92 titled docs: gsd-method revision 2 from the Blockvalley Phase 1 retro; do not open a second PR.
What Changed
kept/changed/parkedscope-delta reconciliation with live-worker acknowledgments.Risk Assessment
✅ Low: The documentation-only change satisfies the stated requirements and preserves the corrected heading and named-proof success signal.
Testing
Focused documentation-audience behavior, Markdown rendering, visual presentation, whitespace, and worktree custody all passed. Evidence was written to the permitted evidence directory. fm-lint.sh and other lint/static-analysis phases were intentionally left to the outer executor, while the audience checker was exercised through its focused test.
Evidence: Rendered overview
Source: Rendered overview
Evidence: Rendered rules
Source: Rendered rules
Evidence: Rendered proof and cost
Source: Rendered proof and cost
Evidence: Rendered HTML
Source: Rendered HTML
Portable HTML render of the target document.Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 3 issues found → auto-fixed ✅
docs/gsd-method.md:46- The intent says to keep the existing Don't-Hand-Roll structure without restyling it, but this renames### 3.4 The Don't-Hand-Roll listto... audit, changing its public heading and anchor. Retain the existing heading or confirm the intentional rename.docs/gsd-method.md:123- The existing success signal requiring the build to hit its named proof without a re-plan was removed. The new capture rule only constrains an on-phone proof if one is attempted, so a phase can now land without any named proof and bypass the proof-triggered check-in; restore the existing signal alongside the new contract.docs/gsd-method.md:137- The cost rule uses unscoped singular fields while its rationale identifies missing complete worker, model, and wall-time totals. A multi-worker phase can satisfy this wording with only the check-in poster's values; define phase-wide totals or require per-worker records plus totals.🔧 Fix: Restored heading and named-proof signal; focused diff check passed
✅ Re-checked - no issues remain.
✅ **Test** - passed
✅ No issues found.
tests/fm-documentation-audiences.test.shgit diff --check 28d7049036bee2a92c7dc82b38501c1fae731680 372e974b4e727f9d81116c1c4c3fd6792a95cab5pandoc docs/gsd-method.md --from=gfm --to=html5 --standaloneIsolated Chrome render and screenshots at 1440x1200Manual scope review of the target diffgit status --short --untracked-files=allandgit diff --quiet HEAD --✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.