chore: Allow targetting locally running backend#17844
Merged
akshaymankar merged 3 commits intodevfrom Jul 31, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #17844 +/- ##
=======================================
Coverage 46.46% 46.46%
=======================================
Files 770 770
Lines 25133 25133
Branches 5744 5745 +1
=======================================
Hits 11677 11677
Misses 11986 11986
Partials 1470 1470 |
2 tasks
tlebon
reviewed
Jul 31, 2024
Co-authored-by: Timothy LeBon <tlebon@gmail.com>
|
tlebon
approved these changes
Jul 31, 2024
Contributor
|
thanks for supporting the web team, we are hiring ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
http://localhost:4570serves the fake S3 service when running backend locally. So it needs to be part ofconnect-srcin the CSP header.The backend doesn't run with TLS for client API locally, so it needs to be connected to without TLS. If the webapp server runs on TLS, the websocket connection is automatically upgraded to TLS too, so the webapp server also needs to run without TLS.
Finally there were some CSP issues when running webapp server on runs on
http://local.zinfra.io:8081, moving it tohttp://localhost:8081fixes it. I am not sure what this one is.Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers
(Delete this section if unnecessary)