Skip to content

chore: Allow targetting locally running backend#17844

Merged
akshaymankar merged 3 commits intodevfrom
target-local-backend
Jul 31, 2024
Merged

chore: Allow targetting locally running backend#17844
akshaymankar merged 3 commits intodevfrom
target-local-backend

Conversation

@akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Jul 31, 2024

Description

http://localhost:4570 serves the fake S3 service when running backend locally. So it needs to be part of connect-src in the CSP header.

The backend doesn't run with TLS for client API locally, so it needs to be connected to without TLS. If the webapp server runs on TLS, the websocket connection is automatically upgraded to TLS too, so the webapp server also needs to run without TLS.

Finally there were some CSP issues when running webapp server on runs on http://local.zinfra.io:8081, moving it to http://localhost:8081 fixes it. I am not sure what this one is.

Screenshots/Screencast (for UI changes)

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • can be reviewed commit-by-commit

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.46%. Comparing base (be2c022) to head (818fa89).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #17844   +/-   ##
=======================================
  Coverage   46.46%   46.46%           
=======================================
  Files         770      770           
  Lines       25133    25133           
  Branches     5744     5745    +1     
=======================================
  Hits        11677    11677           
  Misses      11986    11986           
  Partials     1470     1470           

Co-authored-by: Timothy LeBon <tlebon@gmail.com>
@sonarqubecloud
Copy link

@tlebon
Copy link
Contributor

tlebon commented Jul 31, 2024

thanks for supporting the web team, we are hiring ;)

@akshaymankar akshaymankar merged commit d813c07 into dev Jul 31, 2024
@akshaymankar akshaymankar deleted the target-local-backend branch July 31, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants