Enable manual usage of locally running wire-server #4176
Enable manual usage of locally running wire-server #4176akshaymankar merged 7 commits intodevelopfrom
Conversation
770c444 to
f3834aa
Compare
supersven
left a comment
There was a problem hiding this comment.
Some minor nitpicks. Other than that: LGTM 👍
There was a problem hiding this comment.
In a perfect world, webapp would have a nix environment because NodeJS et. al. aren't endlessly backwards compatible...
There was a problem hiding this comment.
Yes, I was thinking, but then I thought clearly noone would maintain that. So, its probably fine to just nix shell nixpkgs#nodejs ...
There was a problem hiding this comment.
I'm usually too lazy to calculate and would write a let or where binding for such numbers. E.g. fiftysixDays = 4838400.
But, that's probably a matter of taste 😄
There was a problem hiding this comment.
I copy pasted these from default values of the helm charts and I have no clue what they correspond to, I'd wager noone would care about this until they testing something specific at which point they'd probably just change the values temporarily.
d2b4c1f to
f6cf253
Compare
Co-authored-by: Sven Tennie <sven.tennie@wire.com>
f6cf253 to
94d5957
Compare
Webapp repository needed a little change for this to work: wireapp/wire-webapp#17844
Checklist
changelog.d