Skip to content

Enable manual usage of locally running wire-server #4176

Merged
akshaymankar merged 7 commits intodevelopfrom
local-manual-usage
Oct 17, 2024
Merged

Enable manual usage of locally running wire-server #4176
akshaymankar merged 7 commits intodevelopfrom
local-manual-usage

Conversation

@akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Jul 31, 2024

Webapp repository needed a little change for this to work: wireapp/wire-webapp#17844

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 31, 2024
@akshaymankar akshaymankar marked this pull request as ready for review July 31, 2024 10:26
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks. Other than that: LGTM 👍

Copy link
Contributor

@supersven supersven Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a perfect world, webapp would have a nix environment because NodeJS et. al. aren't endlessly backwards compatible...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was thinking, but then I thought clearly noone would maintain that. So, its probably fine to just nix shell nixpkgs#nodejs ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually too lazy to calculate and would write a let or where binding for such numbers. E.g. fiftysixDays = 4838400.

But, that's probably a matter of taste 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy pasted these from default values of the helm charts and I have no clue what they correspond to, I'd wager noone would care about this until they testing something specific at which point they'd probably just change the values temporarily.

Co-authored-by: Sven Tennie <sven.tennie@wire.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants