Conversation
zebot
added
the
ok-to-test
elland
commented
Oct 22, 2024
| # Clean | ||
| .PHONY: full-clean | ||
| full-clean: clean | ||
| make rabbit-clean |
Contributor
Author
There was a problem hiding this comment.
We call it before we delete the env, otherwise rabbitmqadmin is not available.
elland
changed the title
elland
added
echoes: technical-roadmap/technical-debt
fisx
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a first step, this adds weeding to the sanitize-pr step, next step would be making it part of our CI linting step.
I also sneaked in a small change around using verification code subsystems, we've had the effect for a while, but it was unused.
Checklist
changelog.d