Move test documentation tags from proteus to MLS#4240
Merged
pcapriotti merged 4 commits intodevelopfrom Sep 17, 2024
Merged
Conversation
Add `ConversationProtocol` parameter so that this test is run with both supported protocols (Proteus and MLS).
Deleted some of the documentation start and ending tags from Proteus tests and added them to some of the MLS tests. Deleted tags from: - `postCryptoMessageVerifyMsgSentAndRejectIfMissingClient` - `postCryptoMessageVerifyRejectMissingClientAndRepondMissingPrekeysJson` - `postCryptoMessageVerifyRejectMissingClientAndRespondMissingPrekeysProto` - `postMessageClientNotInGroupDoesNotReceiveMsg` - `postMessageRejectIfMissingClients` - `postCryptoMessageVerifyCorrectResponseIfIgnoreAndReportMissingQueryParam` - `postMessageQualifiedLocalOwningBackendMissingClients` Added tags to - `testSenderNotInConversation` - `testApplicationMessage` - `testExternalCommitNotMember ` - `testCommitNotReferencingAllProposals ` - `testAddUserPartial`
zebot
added
the
ok-to-test
echoes-hq
bot
added
the
echoes: product-roadmap
mythsunwind
suggested changes
Sep 16, 2024
Contributor
mythsunwind
left a comment
mythsunwind
left a comment
There was a problem hiding this comment.
Thanks for the great work! I will add the new MLS tests to the mapping so they are picked up for the evaluator documents.
You might have missed to remove comments from 2 tests in services/galley/test/integration/API.hs though. Can you recheck?
Additionally: Can this be merged into the zulu SP1 branch? Not sure what the merging strategy is here or if it needs to be merged to develop first?
Contributor
Author
|
Thanks for the review!
Yes, we merge to develop first. |
mythsunwind
approved these changes
Sep 16, 2024
pcapriotti
added a commit
that referenced
this pull request
Sep 17, 2024
* Parametrise testAccessUpdateGuestRemoved Add `ConversationProtocol` parameter so that this test is run with both supported protocols (Proteus and MLS). * Move test doc tags from proteus to MLS Deleted some of the documentation start and ending tags from Proteus tests and added them to some of the MLS tests. Deleted tags from: - `postCryptoMessageVerifyMsgSentAndRejectIfMissingClient` - `postCryptoMessageVerifyRejectMissingClientAndRepondMissingPrekeysJson` - `postCryptoMessageVerifyRejectMissingClientAndRespondMissingPrekeysProto` - `postMessageClientNotInGroupDoesNotReceiveMsg` - `postMessageRejectIfMissingClients` - `postCryptoMessageVerifyCorrectResponseIfIgnoreAndReportMissingQueryParam` - `postMessageQualifiedLocalOwningBackendMissingClients` Added tags to - `testSenderNotInConversation` - `testApplicationMessage` - `testExternalCommitNotMember ` - `testCommitNotReferencingAllProposals ` - `testAddUserPartial` * Delete more test tags * Add CHANGELOG entry * Fix typos in test names
This was referenced Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move test doc tags from proteus to MLS
Deleted some of the documentation start and ending tags from Proteus
tests and added them to some of the MLS tests.
Deleted tags from:
postCryptoMessageVerifyMsgSentAndRejectIfMissingClientpostCryptoMessageVerifyRejectMissingClientAndRepondMissingPrekeysJsonpostCryptoMessageVerifyRejectMissingClientAndRespondMissingPrekeysProtopostMessageClientNotInGroupDoesNotReceiveMsgpostMessageRejectIfMissingClientspostCryptoMessageVerifyCorrectResponseIfIgnoreAndReportMissingQueryParampostMessageQualifiedLocalOwningBackendMissingClientsAdded tags to
testSenderNotInConversationtestApplicationMessagetestExternalCommitNotMembertestCommitNotReferencingAllProposalstestAddUserPartialAlso generalised
testAccessUpdateGuestRemovedto work with both MLS and Proteus conversations.https://wearezeta.atlassian.net/browse/WPB-10894
Checklist
changelog.d