Skip to content

Backport #4240#4241

Merged
pcapriotti merged 5 commits intoq1-2024from
test-doc-tags-q1
Sep 17, 2024
Merged

Backport #4240#4241
pcapriotti merged 5 commits intoq1-2024from
test-doc-tags-q1

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Sep 16, 2024 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-10894

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti
Parametrise testAccessUpdateGuestRemoved
5719706 
Add `ConversationProtocol` parameter so that this test is run with both
supported protocols (Proteus and MLS).
@pcapriotti
Move test doc tags from proteus to MLS
42cde55 
Deleted some of the documentation start and ending tags from Proteus
tests and added them to some of the MLS tests.

Deleted tags from:
- `postCryptoMessageVerifyMsgSentAndRejectIfMissingClient`
- `postCryptoMessageVerifyRejectMissingClientAndRepondMissingPrekeysJson`
- `postCryptoMessageVerifyRejectMissingClientAndRespondMissingPrekeysProto`
- `postMessageClientNotInGroupDoesNotReceiveMsg`
- `postMessageRejectIfMissingClients`
- `postCryptoMessageVerifyCorrectResponseIfIgnoreAndReportMissingQueryParam`
- `postMessageQualifiedLocalOwningBackendMissingClients`

Added tags to

- `testSenderNotInConversation`
- `testApplicationMessage`
- `testExternalCommitNotMember `
- `testCommitNotReferencingAllProposals `
- `testAddUserPartial`
@pcapriotti
Delete more test tags
a115ea7
@echoes-hq echoes-hq bot added echoes: unplanned Any work item that isn’t part of the product or technical roadmap. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: throughput/ci-maintenance labels Sep 16, 2024
@stefanwire stefanwire changed the base branch from develop to q1-2024 September 16, 2024 14:51
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 17, 2024
@pcapriotti pcapriotti marked this pull request as ready for review September 17, 2024 09:16
@pcapriotti pcapriotti merged commit fcc9c79 into q1-2024 Sep 17, 2024
@pcapriotti pcapriotti deleted the test-doc-tags-q1 branch September 17, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanwire stefanwire stefanwire approved these changes

Assignees

No one assigned

Labels

echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcapriotti @stefanwire @zebot