Conversation
zebot
added
the
ok-to-test
battermann
changed the title
mdimjasevic
reviewed
Sep 10, 2024
mdimjasevic
approved these changes
Sep 10, 2024
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
There are still a few small things to do, but this looks good.
fisx
reviewed
Sep 11, 2024
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
i can't think of anything that we may have missed, but i'm not entirely confident that we haven't... 🤔
lots of comments, most of them do not require action.
fisx
requested changes
Sep 11, 2024
fisx
approved these changes
Sep 12, 2024
Contributor
|
hints for merge conflict resolution with #4218:
All other conflicts should be trivial. us: them: |
failing test basic implementation with holes email sending function no impl dummy endpoint for accepting invitation failing test that user is added to team todo honor timeout refactoring to make findInvitation reuseable accept invitation extend test, publich events test for team id, include team in es doc version assert notification to user sent when fanoutsize is low Add email invitation placeholder Revert "when fanoutsize is low" This reverts commit 0834e48. update nginz confs added errors clean up/renaming email sending Add change logs setting invite url in configmap verify invitation url query parameter release notes clean up move code to http helpers extend golden tests renaming use same timeout settings for all invitations fix format email html add password test (failing) Check if the user password is correct fix test in CI test user cannot join multiple teams Simplify a helper function type Guard against accepting multiple team invitations Throw a suitable invitation not found error
Contributor
|
backup branch before rebase: WPB-10658-invitation-and-acceptance-of-individual-users-to-teams-bakleif |
fisx
force-pushed
the
WPB-10658-invitation-and-acceptance-of-individual-users-to-teams
branch
from
70d8dd5 to
440606c
Compare
Contributor
|
there are some conflicts left from the rebase, just follow the compiler errors. |
fisx
reviewed
Sep 13, 2024
battermann
force-pushed
the
WPB-10658-invitation-and-acceptance-of-individual-users-to-teams
branch
from
b527e6c to
78a4068
Compare
- invitations are distinct - cannot invite user from another team
fisx
approved these changes
Sep 16, 2024
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
i'd like to look into acceptTeamInvitationByPersonalUser, but if you don't want to do that here that's fine, too. :)
| Local UserId -> | ||
| AcceptTeamInvitation -> | ||
| (Handler r) () | ||
| acceptTeamInvitationByPersonalUser luid req = do |
Contributor
There was a problem hiding this comment.
maybe this function could be reorganized to be a little clearer?
fisx
deleted the
WPB-10658-invitation-and-acceptance-of-individual-users-to-teams
branch
This was referenced Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-10658
Checklist
changelog.d