[WPB-8887] wire-subsystems: implement the GetBy* account queries, includes InvitationCodeStore. by MangoIV · Pull Request #4218 · wireapp/wire-server

MangoIV · 2024-08-19T16:06:44Z

https://wearezeta.atlassian.net/browse/WPB-8887

new Effect operation GetAccountBy in UserSubsystem
new record GetBy
new stores ActivationCodeStore and InvitationCodeStore
new sql quasiquoter in cassandra-util
some more Ord instances derived
new function tSplit for the use with ViewPatterns
drive-by cleaning up invitation accessors

The remaining part of the ticket will be addressed in a separate PR.

Checklist

Add a new entry in an appropriate subdirectory of changelog.d
Read and follow the PR guidelines

libs/wire-subsystems/src/Wire/InvitationCodeStore.hs

libs/wire-api/src/Wire/API/Team/Invitation.hs

libs/types-common/src/Wire/Timeout.hs

libs/wire-api/src/Wire/API/Team/Invitation.hs

libs/wire-subsystems/src/Wire/ActivationCodeStore/Cassandra.hs

libs/wire-subsystems/src/Wire/InvitationCodeStore.hs

libs/wire-subsystems/src/Wire/InvitationCodeStore/Cassandra.hs

libs/wire-subsystems/src/Wire/InvitationCodeStore.hs

libs/wire-subsystems/src/Wire/UserStore.hs

libs/wire-subsystems/src/Wire/UserStore/Cassandra.hs

libs/wire-subsystems/src/Wire/InvitationCodeStore.hs

changelog.d/5-internal/wpb-8887

libs/wire-subsystems/src/Wire/InvitationCodeStore/Cassandra.hs

libs/types-common/src/Wire/Timeout.hs

tools/stern/stern.cabal

libs/types-common/src/Wire/Timeout.hs

libs/wire-subsystems/src/Wire/UserSubsystem/Interpreter.hs

libs/wire-subsystems/test/unit/Wire/MockInterpreters/InvitationCodeStore.hs

services/brig/src/Brig/Team/API.hs

changelog.d/5-internal/wpb-8887

fisx · 2024-09-02T09:11:03Z

didn't we decide to leave account stuff out of this PR, and make it only about Invitations?

elland

libs/wire-subsystems/src/Wire/InvitationCodeStore/Cassandra.hs

…nto mangoiv/wpb-8887

fisx · 2024-09-12T13:28:10Z

this took wayyyy too long, but not wayyyyyyyy to long :) i think the result is quite valuable.

…nto mangoiv/wpb-8887

echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Aug 19, 2024

MangoIV changed the title ~~[WPB-8887] initial impl for GetBy* account queries as Effect and interpreter~~ [WPB-8887] wire-subsystems: implement the GetBy* account queries Aug 19, 2024

zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 19, 2024

MangoIV force-pushed the mangoiv/wpb-8887 branch from 279df7a to 167d679 Compare August 21, 2024 07:12

mdimjasevic self-requested a review August 21, 2024 09:58

elland force-pushed the mangoiv/wpb-8887 branch from d7ac8ac to 91b23d1 Compare August 22, 2024 12:30

MangoIV commented Aug 22, 2024

View reviewed changes

libs/wire-subsystems/src/Wire/InvitationCodeStore.hs Outdated Show resolved Hide resolved

elland force-pushed the mangoiv/wpb-8887 branch from c64e1b8 to 80d3c89 Compare August 26, 2024 07:14

MangoIV commented Aug 26, 2024

View reviewed changes

libs/wire-api/src/Wire/API/Team/Invitation.hs Outdated Show resolved Hide resolved

elland force-pushed the mangoiv/wpb-8887 branch 3 times, most recently from 13c7eaf to 6fbb7ec Compare August 27, 2024 14:23

fisx force-pushed the mangoiv/wpb-8887 branch from 7562f16 to 6fbb7ec Compare August 29, 2024 08:06

elland marked this pull request as ready for review August 29, 2024 08:06