[feat] use new script for sbom generation#3942
Merged
Conversation
zebot
added
the
ok-to-test
emil-wire
reviewed
Mar 13, 2024
MangoIV
commented
Mar 13, 2024
fisx
reviewed
Mar 18, 2024
MangoIV
force-pushed
the
mangoiv/sbom-generation
branch
2 times, most recently
from
7558ff7 to
5727288
Compare
MangoIV
force-pushed
the
mangoiv/sbom-generation
branch
from
5727288 to
c0c7c46
Compare
MangoIV
force-pushed
the
mangoiv/sbom-generation
branch
from
c0c7c46 to
52eb2ec
Compare
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
supersven
reviewed
Apr 11, 2024
Co-authored-by: Sven Tennie <sven.tennie@wire.com>
emil-wire
approved these changes
Apr 12, 2024
Contributor
Author
|
@supersven thank you for your review; I have tried to address your issues, would you happen to have time to take one more glance at it? :3 Thank you! |
MangoIV
force-pushed
the
mangoiv/sbom-generation
branch
from
e6bc7d9 to
2341fd1
Compare
Contributor
@MangoIV I'm at it 😄 |
supersven
reviewed
Apr 15, 2024
Co-authored-by: Sven Tennie <sven.tennie@wire.com>
supersven
reviewed
Apr 15, 2024
| deriving stock (Eq, Ord, Show, Generic) | ||
| deriving anyclass (FromJSON, ToJSON) | ||
|
|
||
| sadSbomMeta :: Text -> Text -> [Text] -> SBomMeta Identity |
Contributor
There was a problem hiding this comment.
Suggested change
| sadSbomMeta :: Text -> Text -> [Text] -> SBomMeta Identity | |
| emptySbomMeta :: Text -> Text -> [Text] -> SBomMeta Identity |
or
Suggested change
| sadSbomMeta :: Text -> Text -> [Text] -> SBomMeta Identity | |
| notFoundSbomMeta :: Text -> Text -> [Text] -> SBomMeta Identity |
?
Hm, could be that I don't get the name 🤔 However, if this is named "sad" because the search algorithm is sad because it didn't find anything, then I would say be can name this better 😃
Contributor
Author
There was a problem hiding this comment.
yeah, it's because it didn't find anything and the information it can provide is sad :(
Contributor
There was a problem hiding this comment.
As said empty... or notFound... would have been easier to grap. 😸
supersven
reviewed
Apr 15, 2024
supersven
reviewed
Apr 15, 2024
supersven
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SEC-596
Checklist
changelog.d