galley: Cleanup garbage data in mls_group_member_client table and drop unused member_client table#3648
Merged
mdimjasevic merged 4 commits intodevelopfrom Oct 13, 2023
Merged
Conversation
Pre MLS draft-17, the table didn't have a couple of fields. Nothing in the API blocked creation of MLS clients in prod. So, the table might now contain some nulls which the application code doesn't handle very well. This will get rid of all such clients as it is easier to do this than to expect the nulls.
The table is unused.
zebot
added
the
ok-to-test
pcapriotti
approved these changes
Oct 12, 2023
Member
Author
|
Actually, maybe we should add something to the release notes to warn people about having used an undocumented feature 😅 |
That table doesn't exist anymore, so the data migration will fail.
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-5033
Checklist
changelog.d