Skip to content

[WPB-3888] Make sure cassandra updates do not re-introduce removed content. #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fisx merged 4 commits into from
Aug 16, 2023
Merged

[WPB-3888] Make sure cassandra updates do not re-introduce removed content. #3504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
448a93f
Fix inconsistent client list error (happened in prod).
fisx Aug 16, 2023
d7e17c7
Changelog.
fisx Aug 16, 2023
383c749
Fix all occurrances of the issue.
fisx Aug 16, 2023
44da604
Revert "Fix all occurrances of the issue."
fisx Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/3-bug-fixes/wpb-3888
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make sure cassandra updates do not re-introduce removed content.
2 changes: 1 addition & 1 deletion services/brig/src/Brig/Data/Client.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ updateClientCapabilitiesQuery :: PrepQuery W (Maybe (C.Set ClientCapability), Us
updateClientCapabilitiesQuery = "UPDATE clients SET capabilities = ? WHERE user = ? AND client = ?"

updateClientLastActiveQuery :: PrepQuery W (UTCTime, UserId, ClientId) ()
updateClientLastActiveQuery = "UPDATE clients SET last_active = ? WHERE user = ? AND client = ?"
updateClientLastActiveQuery = "UPDATE clients SET last_active = ? WHERE user = ? AND client = ? IF EXISTS"

selectClientIds :: PrepQuery R (Identity UserId) (Identity ClientId)
selectClientIds = "SELECT client from clients where user = ?"
Expand Down