Skip to content

old-ingress-stop-logging-query-parameters #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jschaul merged 1 commit into from
Mar 21, 2023
Merged

old-ingress-stop-logging-query-parameters #3139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/3-bug-fixes/ingress-controller-logs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
When using the (now deprecated) ingress controller on older versions of kubernetes, ensure query parameters are not logged in the ingress logs
7 changes: 7 additions & 0 deletions charts/nginx-ingress-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ nginx-ingress:
http2-max-header-size: 32k
proxy-buffer-size: 16k
proxy-body-size: 1024m

# custom log format, remove query parameters from logs as they sometimes contain sensitive information like access tokens (context: websocket establishment in browsers)
# See also SEC-47 for context.
# default log format (for image 0.30.0) in
# https://github.com/kubernetes/ingress-nginx/blob/49f20f849cc13564691acc49f639955f02f3c75e/docs/user-guide/nginx-configuration/configmap.md
# If ever needing to debug query parameter usage, you can use the (sanitized) logs from nginz instead.
log-format-upstream: '$remote_addr - $remote_user [$time_local] "$request_method $uri" $status $body_bytes_sent "$http_referer" "$http_user_agent" $request_length $request_time [$proxy_upstream_name] [$proxy_alternative_upstream_name] $upstream_addr $upstream_response_length $upstream_response_time $upstream_status $req_id'
# Normally, NodePort will listen to traffic on all nodes, and uses kube-proxy
# to redirect to the node that actually runs nginx-ingress-controller. However
# one problem with this is that this traffic is NAT'ed. This means that nginx
Expand Down