Skip to content

Comments

old-ingress-stop-logging-query-parameters#3139

Merged
jschaul merged 1 commit intodevelopfrom
ingress-logs
Mar 21, 2023
Merged

old-ingress-stop-logging-query-parameters#3139
jschaul merged 1 commit intodevelopfrom
ingress-logs

Conversation

@jschaul
Copy link
Member

@jschaul jschaul commented Mar 9, 2023 •
edited
Loading

For the new ingress controller, see #3140

https://wearezeta.atlassian.net/browse/SEC-47

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 9, 2023
comawill
comawill approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@comawill comawill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jschaul jschaul merged commit eccf052 into develop Mar 21, 2023
@jschaul jschaul deleted the ingress-logs branch March 21, 2023 16:23
supersven pushed a commit that referenced this pull request Mar 22, 2023
@jschaul @supersven
old-ingress-stop-logging-query-parameters (#3139)
7642a5f
@zebot zebot mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshaymankar akshaymankar Awaiting requested review from akshaymankar

@supersven supersven Awaiting requested review from supersven

1 more reviewer

@comawill comawill comawill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jschaul @comawill @zebot