[SQSERVICES-1843] Outlook calendar feature flag#3025
Conversation
zebot
added
the
ok-to-test
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
plus some nit-picks, and some bugs (i think).
(you can now just run ./services/start-services-only.sh and stern is already running. cool, didn't know that!)
services/galley/schema/src/V78_TeamFeatureCalendarIntegration.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Check lock status like in ExposeInvitationURLsToTeamAdminConfig above?
There was a problem hiding this comment.
I think, we don't want to check if the feature is locked here. This is an internal function and the necessary checks should already been made before this is called. And specifically for PATCH we want to allow overriding the team feature status even if locked because this is used by IBIS.
There was a problem hiding this comment.
then why does the instance above do it? and why would ibis be allowed to break locks? ah, i see. it's locked for team admins, but ibis still needs to touch it.
oh dear what a mess.
There was a problem hiding this comment.
I don't understand why the function above does the check, either. I am currently trying to clarify this. Maybe it is a mistake.
It used to be much messier, believe me :)
|
I think the CI error can be ignored / fixed elsewhere. |
|
anyway how does this flag work? what does it do? i suppose this depends on #2989 after all, so should be added in a third PR, maybe? |
Probably due to GHC upgrade, should work after develop is merged into this branch. |
|
could you reproduce the error in stern? |
Yes, IMO this has nothing to do with this PR and is a general problem. The error occurs if the feature is locked. If you unlock the feature with curl, then it works. However, IIRC it used to be possible to lock or unlock features via backoffice/stern, but these endpoints have somehow disappeared. Strange. I'd tend to solve this problem in a separate PR. |
battermann
force-pushed
the
SQSERVICES-1843-be-oauth-feature-flag-rebase-develop
branch
from
e8b6c80 to
ce44c0d
Compare
battermann
deleted the
SQSERVICES-1843-be-oauth-feature-flag-rebase-develop
branch
|
|
||
| ## Outlook calalendar integration | ||
|
|
||
| This feature setting only applies to the Outlook Calendar extension for Wire. As it is an external service, it should only be configured through this feature flag and otherwise ignored by the backend. |
There was a problem hiding this comment.
s/As it is an external service, it should only be configured through this feature flag and otherwise ignored by the backend./This does not change the behavior of the backend, but it will be consulted by the [calendar integration service](TODO: which repo? ask dejan?), which will adopt its behavior accordingly./
3 participants
https://wearezeta.atlassian.net/browse/SQSERVICES-1843
Checklist
changelog.d