Conversation
zebot
added
the
ok-to-test
Co-authored-by: Florian Klink <flokli@flokli.de>
amitsagtani97
changed the title
amitsagtani97
force-pushed
the
add_roman_chart
branch
from
02089c7 to
7f748a9
Compare
jschaul
left a comment
jschaul
left a comment
There was a problem hiding this comment.
I did not test this chart, there may be problems; but glancing at it it looks mostly fine. See comments inline for some suggested improvements.
| @@ -0,0 +1 @@ | |||
| Roman charts are now available. | |||
There was a problem hiding this comment.
| Roman charts are now available. | |
| A helm chart for the bot 'Roman' is now available. |
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.1.0 |
There was a problem hiding this comment.
| version: 0.1.0 | |
| version: 0.0.42 |
| @@ -0,0 +1,23 @@ | |||
| apiVersion: extensions/v1beta1 | |||
There was a problem hiding this comment.
please change the ingress apiVersion for maximum kubernetes version compatibility as done in #3002: add some function to _helpers.tpl and adjust the ingress.yaml in the same fashion as done in that PR for other charts, e.g. the nginx-ingress-services one.
| tag: staging | ||
| serviceToken: # Provide the roman service token. | ||
| # randomly generated for local testing | ||
| appKey: b53181dd-6400-4960-8988-f775545588ff-0949f503-421e-4588-a2c5-f64fd9c180fd |
There was a problem hiding this comment.
I would comment out most of these variables. It's useful for people installing the chart to have an idea of what an example value looks like; but it's not a good idea if people mistakenly use these default values as they forget to override them. It would be better to have the chart fail to install if a variable is missing.
|
You also need to add this chart to wire-server/Makefile 's list of charts to release (see at the top of the makefile there's a space-separated list of chart names). |
|
|
|
This has been untouched for about 2 years now. And, |
7 participants
Checklist
Example values file for both charts can be found at - wireapp/wire-server-deploy#597
changelog.d