[DO NOT MERGE] add examples values for roman#597
Open
amitsagtani97 wants to merge 2 commits intomasterfrom
Open
[DO NOT MERGE] add examples values for roman#597amitsagtani97 wants to merge 2 commits intomasterfrom
amitsagtani97 wants to merge 2 commits intomasterfrom
Conversation
2 tasks
julialongtin
requested changes
Jan 5, 2023
| image: | ||
| repository: quay.io/wire/roman | ||
| # Overrides the image tag whose default is the chart appVersion. | ||
| tag: staging |
Member
There was a problem hiding this comment.
do we really not have a production tag for this?
| tag: staging | ||
| serviceToken: # Provide the roman service token. | ||
| # randomly generated for local testing | ||
| appKey: b53181dd-6400-4960-8988-f775545588ff-0949f503-421e-4588-a2c5-f64fd9c180fd |
Member
There was a problem hiding this comment.
and how is the user supposed to randomly generate this?
| serviceToken: # Provide the roman service token. | ||
| # randomly generated for local testing | ||
| appKey: b53181dd-6400-4960-8988-f775545588ff-0949f503-421e-4588-a2c5-f64fd9c180fd | ||
| wireApiHost: https://nginz-https.example.com |
Member
There was a problem hiding this comment.
this is totally wrong. look at the prod-values.example.yaml . when referring to a wire component, we don't use FQDNs.
| wireApiHost: https://nginz-https.example.com | ||
| proxyDomain: | ||
| # random base 64 string used as certificate, replace with real one | ||
| pubKeyBase64: LS0tLS1CRUdJTiBQVcFQvWjcKMlczd1A1TzJveFVCTElDIEtFWS0tLS0tCg== |
Member
There was a problem hiding this comment.
again, how is a user supposed to use this, and.. what kind of cert is this?
| # random base 64 string used as certificate, replace with real one | ||
| pubKeyBase64: LS0tLS1CRUdJTiBQVcFQvWjcKMlczd1A1TzJveFVCTElDIEtFWS0tLS0tCg== | ||
| publicURL: roman.example.com # Link to the subdomain pointing to roman. | ||
| dbURL: jdbc:postgresql://postgresql:5432/externalPostgresql # Link to your Postgres server. |
Member
There was a problem hiding this comment.
this should point to the ephemeral postgres, by default.
| dbUser: externalPostgresql # Provide your Postgres DB username. | ||
| dbPassword: externalPostgresql # Provide your Postgres DB password. | ||
|
|
||
| tls: |
Member
There was a problem hiding this comment.
is there a way to supply certificates other than letsEncrypt?
amitsagtani97
changed the title
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example values for roman and postgresql13-ephemeral chart.
Depends on - wireapp/wire-server#2935