Skip to content

Update PR guideline docs #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
battermann merged 2 commits into from
Nov 30, 2022
Merged

Update PR guideline docs #2889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5971574
Update PR guideline docs
battermann Nov 30, 2022
90895a4
changelog
battermann Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/4-docs/pr-2889
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
PR guidelines docs are updated with correct helm configuration syntax
9 changes: 6 additions & 3 deletions docs/src/developer/developer/pr-guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,13 @@ The following needs to be done, as part of a PR adding endpoints or changing end
### Helm configuration

For internal endpoints for QA access on staging environments, copy a block with `/i/` containing

```
zauth: false
basic_auth: true
whitelisted_envs: ['staging']
- path: /some/path
envs:
- staging
disable_zauth: true
basic_auth: true
```

For customer support access to an internal endpoint, instead update code in [stern](https://github.com/wireapp/wire-server/tree/develop/tools/stern) as part of your PR. There is no need to add that endpoint to nginz.
Expand Down