Skip to content

Comments

Update PR guideline docs#2889

Merged
battermann merged 2 commits intodevelopfrom
battermann/update-pr-guideline-docs
Nov 30, 2022
Merged

Update PR guideline docs#2889
battermann merged 2 commits intodevelopfrom
battermann/update-pr-guideline-docs

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Nov 30, 2022 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann temporarily deployed to cachix November 30, 2022 15:59 Inactive
@battermann battermann temporarily deployed to cachix November 30, 2022 15:59 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 30, 2022
@battermann battermann temporarily deployed to cachix November 30, 2022 16:01 Inactive
@battermann battermann temporarily deployed to cachix November 30, 2022 16:01 Inactive
@battermann battermann force-pushed the battermann/update-pr-guideline-docs branch from 75a4673 to 90895a4 Compare November 30, 2022 16:03
@battermann battermann temporarily deployed to cachix November 30, 2022 16:03 Inactive
@battermann battermann temporarily deployed to cachix November 30, 2022 16:03 Inactive
@battermann battermann requested a review from smatting November 30, 2022 16:03
@battermann battermann merged commit d6ec827 into develop Nov 30, 2022
@battermann battermann deleted the battermann/update-pr-guideline-docs branch November 30, 2022 16:17
@zebot zebot mentioned this pull request Dec 1, 2022
Merged
@zebot zebot mentioned this pull request Dec 1, 2022
Merged
@zebot zebot mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smatting smatting smatting approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@battermann @smatting @zebot