Bump coturn image, update chart config for configurable metrics labels#2498
Merged
Bump coturn image, update chart config for configurable metrics labels#2498
Conversation
flokli
approved these changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our coturn fork previously had username labeling of Prometheus metrics patched out, however wireapp/coturn#7 reintroduced these metrics with a flag to disable them at runtime. This change updates the coturn image to include this change, and updates the configuration in the Helm chart to ensure this functionality remains disabled. This should not introduce any functional changes.
See also https://wearezeta.atlassian.net/browse/SQPIT-1012.
Checklist
make git-add-cassandra-schemato update the cassandra schema documentation.changelog.d.