Skip to content

Comments

Bump coturn image, update chart config for configurable metrics labels#2498

Merged
sysvinit merged 1 commit intodevelopfrom
sysvinit/coturn-metrics-labels
Jun 22, 2022
Merged

Bump coturn image, update chart config for configurable metrics labels#2498
sysvinit merged 1 commit intodevelopfrom
sysvinit/coturn-metrics-labels

Conversation

@sysvinit
Copy link
Contributor

Our coturn fork previously had username labeling of Prometheus metrics patched out, however wireapp/coturn#7 reintroduced these metrics with a flag to disable them at runtime. This change updates the coturn image to include this change, and updates the configuration in the Helm chart to ensure this functionality remains disabled. This should not introduce any functional changes.

See also https://wearezeta.atlassian.net/browse/SQPIT-1012.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@sysvinit sysvinit temporarily deployed to cachix June 20, 2022 14:51 Inactive
@sysvinit sysvinit marked this pull request as ready for review June 20, 2022 14:51
@sysvinit sysvinit merged commit 4d07f4a into develop Jun 22, 2022
@sysvinit sysvinit deleted the sysvinit/coturn-metrics-labels branch June 22, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants