[FS-507] Improve the Federated Welcome Message Request#2412
Merged
mdimjasevic merged 18 commits intodevelopfrom May 25, 2022
Merged
[FS-507] Improve the Federated Welcome Message Request#2412mdimjasevic merged 18 commits intodevelopfrom
mdimjasevic merged 18 commits intodevelopfrom
Conversation
added 3 commits
May 18, 2022 15:42
- This tests the new return type of the endpoint handler
pcapriotti
reviewed
May 19, 2022
added 3 commits
May 19, 2022 11:10
- We never fail when dereferencing on the remote end fails
pcapriotti
approved these changes
May 23, 2022
This was referenced Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An earlier PR #2368 introduced a federated welcome message request
"mls-welcome"that beside a raw welcome message also included the list of recipients. This is not only redundant, but it also opens ground for abuse by allowing to include recipients that are not intended to receive the welcome message. This PR fixes the issue by updating the federated request to carry only the raw welcome message. The endpoint handler decodes the welcome message and also checks for key package references.Tracked by https://wearezeta.atlassian.net/browse/FS-507.
Checklist
changelog.d.