Skip to content

Comments

[FS-507] Support for Remote Welcome Messages#2368

Merged
mdimjasevic merged 21 commits intodevelopfrom
fs-507/remote-welcome-messages
May 12, 2022
Merged

[FS-507] Support for Remote Welcome Messages#2368
mdimjasevic merged 21 commits intodevelopfrom
fs-507/remote-welcome-messages

Conversation

@mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented May 5, 2022 •
edited
Loading

The PR adds support for remote welcome messages. So far only local welcome messages have been supported.

Tracked by https://wearezeta.atlassian.net/browse/FS-507.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@mdimjasevic mdimjasevic temporarily deployed to cachix May 5, 2022 14:04 Inactive
@mdimjasevic mdimjasevic marked this pull request as draft May 5, 2022 14:05
@mdimjasevic mdimjasevic temporarily deployed to cachix May 5, 2022 15:14 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-507/remote-welcome-messages branch from a55fbe6 to 25d09c9 Compare May 6, 2022 11:40
@mdimjasevic mdimjasevic temporarily deployed to cachix May 6, 2022 11:40 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-507/remote-welcome-messages branch from 25d09c9 to 20c655b Compare May 6, 2022 13:15
@mdimjasevic mdimjasevic temporarily deployed to cachix May 6, 2022 13:15 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-507/remote-welcome-messages branch from 20c655b to 764d3a1 Compare May 6, 2022 13:35
@mdimjasevic mdimjasevic temporarily deployed to cachix May 6, 2022 13:35 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-507/remote-welcome-messages branch from 764d3a1 to f9de364 Compare May 6, 2022 13:41
@mdimjasevic mdimjasevic temporarily deployed to cachix May 6, 2022 13:41 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix May 6, 2022 15:12 Inactive
Marko Dimjašević added 3 commits May 9, 2022 13:50
Extend dereferencing of a key package reference
320c309 
- also return a qualified conversation ID (next to a user ID and a
client ID)
First stab at handling remote welcomes
85c0516 
- Any error handling is yet to be implemented
Implement a test for the server side of POST /federation/mls-welcome
63b74b0
@mdimjasevic mdimjasevic force-pushed the fs-507/remote-welcome-messages branch from de69709 to 8f69e35 Compare May 9, 2022 11:51
@mdimjasevic mdimjasevic temporarily deployed to cachix May 9, 2022 11:51 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-507/remote-welcome-messages branch from 8f69e35 to 65659b6 Compare May 9, 2022 14:28
@mdimjasevic mdimjasevic temporarily deployed to cachix May 9, 2022 14:28 Inactive
@smatting smatting temporarily deployed to cachix May 9, 2022 15:44 Inactive
@smatting smatting temporarily deployed to cachix May 10, 2022 11:44 Inactive
@smatting smatting temporarily deployed to cachix May 10, 2022 11:50 Inactive
@smatting smatting temporarily deployed to cachix May 10, 2022 12:08 Inactive
smatting
smatting reviewed May 10, 2022
View reviewed changes
@mdimjasevic mdimjasevic temporarily deployed to cachix May 10, 2022 12:50 Inactive
smatting
smatting reviewed May 10, 2022
View reviewed changes
@mdimjasevic mdimjasevic temporarily deployed to cachix May 11, 2022 06:51 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix May 11, 2022 06:52 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix May 11, 2022 06:53 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix May 11, 2022 06:57 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix May 11, 2022 08:48 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix May 11, 2022 09:12 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix May 11, 2022 09:23 Inactive
@mdimjasevic mdimjasevic requested a review from smatting May 11, 2022 09:24
@mdimjasevic mdimjasevic temporarily deployed to cachix May 11, 2022 09:44 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix May 11, 2022 10:10 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix May 11, 2022 11:15 Inactive
@mdimjasevic mdimjasevic merged commit 4a3bea4 into develop May 12, 2022
@mdimjasevic mdimjasevic deleted the fs-507/remote-welcome-messages branch May 12, 2022 03:46
@mdimjasevic mdimjasevic mentioned this pull request May 18, 2022
Merged
5 tasks
@zebot zebot mentioned this pull request May 18, 2022
Merged
@mdimjasevic mdimjasevic mentioned this pull request May 18, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smatting smatting Awaiting requested review from smatting

1 more reviewer

@stephen-smith stephen-smith stephen-smith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdimjasevic @smatting @stephen-smith